Fix warning and depends of examples/sotest

[JianyuWang0623]

Summary

1. Fix warning of unused variable 'devname' - f876f3b
2. Fix depends of SOTEST_BUILTINFS - c7418f1

Please see commit message for more details.

Impact

examples/sotest

Testing

• Configuration

./tools/configure.sh -l sim:sotest

• Run

nsh> sotest
main: Registering romdisk at /dev/ram3
main: Mounting ROMFS filesystem at target=/mnt/romfs with source=/dev/ram3
module_initialize:
module_initialize:
testfunc1: Hello, everyone!
   caller: Hello to you too!
testfunc2: Hope you are having a great day!
   caller: Not so bad so far.
testfunc3: Let's talk again very soon
   caller: Yes, don't be a stranger!
module_uninitialize: arg=0
module_uninitialize: arg=0
nsh>

[cederom]

Thank you @JianyuWang0623 :-)

• There are too many unrelated changes in this PR, please provide separate dedicated PR for each functional change / area.
• Please remember to provide descriptive git commit messages as well as PR descriptions.

[cederom]

Sorry, but this is a perfect example of really terrible PR:

• Various changes for different functional areas are introduced in one single PR.
• There is zero description on why change is introduced what it does and why (both in commit message and the PR description).
• Impact description in PR misses key points on global build process and other changes that PR would leave after it was merged.
• Testing description in PR does not exist, provides no test logs, nothing.
• We cannot accept this kind of PRs.

I will not close this PR so we could have a discussion and work out better PR submission in future.

[patacongo]

I will not close this PR so we could have a discussion and work out better PR submission in future.

Marking it as Draft will prevent any accidental commits until you discussion is finished.

[patacongo]

• There are too many unrelated changes in this PR, please provide separate dedicated PR for each functional change / area.

There are 8 commits, so the changes have been contained in separate commits, just provided under one PR. So I don't think there is a major problem with the github content after the merge. It is just harder to review when they are combined (but each commit can also be reviewed separately).

Doing things in a consistent way is, however, also important.

[Donny9]

@JianyuWang0623 please split mutli PR～

[cederom]

I think that PR review process needs some improvements, as we get more and more nice PRs, some updates seem necessary also on our side - to provide reporters with basic information that are required in each PR here goes the template update proposition (apache/nuttx#13494). Your feedback is much appreciated! Thank you! :-)

[patacongo]

You should be aware of these

commit a59ae5536c58510a26e5a64868ea0705d1eb1c2b
Author: David Sidrane <[email protected]>
Date:   Sat Apr 18 05:00:11 2020 -0700

    github: Add PR Template

commit bd7217e21ede8a5f42cd5c63a68f68bffece15df
Author: Gregory Nutt <[email protected]>
Date:   Tue Apr 21 08:18:31 2020 -0600

    Remove boilerplate from the PR template.

    So far, the use of the new pull request template has been disastrous.  People are ignoring the writing instructions the template is polluting the PR history.  This change just removes the boilerplate and writing instructions fromt he template.  We don't need to see this unmodified serveral times per day.

All bad memories

[JianyuWang0623]

@cederom @patacongo @Donny9 PR has been splited, and that has comments will be linked here.

[cederom]

Thank you @JianyuWang0623 :-) Smaller and well described changes are much better to process :-)