tools: Allow trigger docker build manually #11641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, we may need to manually trigger the docker image building process, for example, if the automatic build fails due to some reasons. Signed-off-by: Huang Qi <[email protected]>
|
@no1wudi please include the Summary comment in the commit log message! I think a documentation about how to use Docker with NuttX and CI should be nice! I did some initial documentation some time ago: https://acassis.wordpress.com/2023/01/21/how-i-create-a-docker-image-for-nuttx/ , but maybe with your expertise we could improve it and add into NuttX. What do you think? |
|
@acassis Thanks for your information, let me try other approaches first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some cases, we may need to manually trigger the docker image building process, for example, if the automatic build fails due to some reasons.
Make it easier for downstream users to build their docker images.
For example, I‘m maintaining the CI infrastructure for WAMR on the wamr-ci-12.4(based on release/12.4) branch and have added some additional toolchains to the NuttX Dockerfile. If I want the CI to compile the images I need, I must ensure that my modifications to the Dockerfile are applied to the wamr-ci-12.4 branch, while also keeping this PR on the master branch. Considering that I often submit code to NuttX, this will cause some inconvenience (I must have this PR on my master branch to manually trigger the Docker build process).
Impact
Minor
Testing
CI