{bp-12560} espressif: Fix error while evaluating Wi-Fi task ID #12755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `nxsched_gettid` instead of `nxsched_getpid`. Previously each kernel thread was modelled as a task, so the pid is the same of the kthread id. Now, with shared kthread group (introduced by apache#12320), the pid of all kthreads will be 0 by design in shared group.
xiaoxiang781216
approved these changes
Jul 24, 2024
anchao
approved these changes
Jul 24, 2024
tmedicci
approved these changes
Jul 24, 2024
pkarashchenko
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
nxsched_gettidinstead ofnxsched_getpid. Previously each kernel thread was modelled as a task, so the pid is the same of the kthread id. Now, with shared kthread group (introduced by #12320), the pid of all kthreads will be 0 by design in shared group.Impact
RELEASE
Testing
ESP32, ESP32-S3, ESP32-C3