WIP: move readv/writev to the kernel #13498
Draft
+676
−370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiaoxiang781216 can you please review this before i apply the mechanical change to hundreds of files? thank you. |
include/nuttx/fs/fs.h
Outdated
| CODE off_t (*seek)(FAR struct file *filep, off_t offset, int whence); | ||
| CODE int (*ioctl)(FAR struct file *filep, int cmd, unsigned long arg); | ||
| CODE int (*mmap)(FAR struct file *filep, | ||
| FAR struct mm_map_entry_s *map); | ||
| CODE int (*truncate)(FAR struct file *filep, off_t length); | ||
| CODE int (*poll)(FAR struct file *filep, FAR struct pollfd *fds, | ||
| bool setup); | ||
| CODE ssize_t (*compat_read)(FAR struct file *filep, FAR char *buffer, |
| ret = (int)inode->u.i_ops->read(filep, | ||
| (FAR char *)buf, | ||
| (size_t)nbytes); | ||
| ret = inode->u.i_ops->readv(filep, iov, iovcnt); | ||
| } |
There was a problem hiding this comment.
let's fallback to compact_readv here if readv is NULL, instead changing each individual driver or fs.
| * | ||
| ****************************************************************************/ | ||
|
|
||
| ssize_t iovec_compat_readv(FAR struct file *filep, |
There was a problem hiding this comment.
could move to fs_read.c as a static function, and call it directly if driver/fs doesn't implement readv
| * | ||
| ****************************************************************************/ | ||
|
|
||
| ssize_t iovec_compat_writev(FAR struct file *filep, |
* add readv/writev. * rename the existing read/write to compat_read/compat_write they will be only used by compat logic.
largely copy-and-paste from libc/uio
Also, sync CMakeLists.txt with Make.defs. (preadv/pwritev)
|
@xiaoxiang781216 do you prefer the latest push? |
| @@ -227,6 +229,10 @@ struct file_operations | |||
|
|
|||
| CODE int (*poll)(FAR struct file *filep, FAR struct pollfd *fds, | |||
| bool setup); | |||
| CODE ssize_t (*readv)(FAR struct file *filep, FAR const struct iovec *iov, | |||
There was a problem hiding this comment.
could we move the new callback to the end? otherwise all drivers/fs has to been modified.
There was a problem hiding this comment.
where exactly do you mean by "the end"?
| @@ -323,6 +329,11 @@ struct mountpt_operations | |||
| CODE int (*truncate)(FAR struct file *filep, off_t length); | |||
| CODE int (*poll)(FAR struct file *filep, FAR struct pollfd *fds, | |||
| bool setup); | |||
| CODE ssize_t (*readv)(FAR struct file *filep, FAR const struct iovec *iov, | |||
| { | ||
| struct iovec iov; | ||
|
|
||
| iov.iov_base = (void *)buf; |
There was a problem hiding this comment.
Suggested change
| iov.iov_base = (void *)buf; | |
| iov.iov_base = (FAR void *)buf; |
| ****************************************************************************/ | ||
|
|
||
| struct file; | ||
| ssize_t iovec_compat_readv(FAR struct file *filep, |
There was a problem hiding this comment.
should we move to include/nuttx/fs/fs.h
Suggested change
| ssize_t iovec_compat_readv(FAR struct file *filep, | |
| ssize_t file_compat_readv(FAR struct file *filep, |
| * | ||
| ****************************************************************************/ | ||
|
|
||
| ssize_t iovec_compat_writev(FAR struct file *filep, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Testing