drivers/i3c: support i3c driver frameworks #13507
Open
+5,539
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerpelea
approved these changes
Sep 17, 2024
xiaoxiang781216
approved these changes
Sep 17, 2024
Donny9
force-pushed
the
i3c
branch
2 times, most recently
from
558de1b
to
e226d1a
Compare
Done~ |
acassis
approved these changes
Sep 17, 2024
drivers/i3c/device.c
Outdated
| } | ||
|
|
||
| /**************************************************************************** | ||
| * Name: i3c_device_enable_ibi() |
There was a problem hiding this comment.
Suggested change
| * Name: i3c_device_enable_ibi() | |
| * Name: i3c_device_enable_ibi |
drivers/i3c/device.c
Outdated
| } | ||
|
|
||
| /**************************************************************************** | ||
| * Name: i3c_device_disable_ibi() |
There was a problem hiding this comment.
Suggested change
| * Name: i3c_device_disable_ibi() | |
| * Name: i3c_device_disable_ibi |
drivers/i3c/device.c
Outdated
| } | ||
|
|
||
| /**************************************************************************** | ||
| * Name: i3c_device_get_info() |
There was a problem hiding this comment.
Suggested change
| * Name: i3c_device_get_info() | |
| * Name: i3c_device_get_info |
drivers/i3c/device.c
Outdated
| ****************************************************************************/ | ||
|
|
||
| /**************************************************************************** | ||
| * Name: i3c_device_do_priv_xfers() |
There was a problem hiding this comment.
Suggested change
| * Name: i3c_device_do_priv_xfers() | |
| * Name: i3c_device_do_priv_xfers |
drivers/i3c/device.c
Outdated
| } | ||
|
|
||
| /**************************************************************************** | ||
| * Name: i3c_device_request_ibi() |
There was a problem hiding this comment.
Suggested change
| * Name: i3c_device_request_ibi() | |
| * Name: i3c_device_request_ibi |
drivers/i3c/master.c
Outdated
| char devname[12]; | ||
| int i2c_bus_id = i3c_master_to_i2c_bus_number(master); | ||
|
|
||
| snprintf(devname, 12, "/dev/i2c%d", i2c_bus_id); |
There was a problem hiding this comment.
Suggested change
| snprintf(devname, 12, "/dev/i2c%d", i2c_bus_id); | |
| snprintf(devname, sizeof(devname), "/dev/i2c%d", i2c_bus_id); |
drivers/i3c/master.c
Outdated
| } | ||
|
|
||
| /**************************************************************************** | ||
| * Name: i2c_unregister_driver() |
There was a problem hiding this comment.
Suggested change
| * Name: i2c_unregister_driver() | |
| * Name: i2c_unregister_driver |
drivers/i3c/master.c
Outdated
| { | ||
| char devname[12]; | ||
|
|
||
| snprintf(devname, 12, "/dev/i3c%d", i3c_master_to_i3c_bus_number(master)); |
drivers/i3c/master.c
Outdated
| } | ||
|
|
||
| /**************************************************************************** | ||
| * Name: i3c_master_get_free_addr() |
There was a problem hiding this comment.
Suggested change
| * Name: i3c_master_get_free_addr() | |
| * Name: i3c_master_get_free_addr |
drivers/i3c/master.c
Outdated
| } | ||
|
|
||
| /**************************************************************************** | ||
| * Name: i3c_generic_ibi_get_free_slot() |
There was a problem hiding this comment.
Suggested change
| * Name: i3c_generic_ibi_get_free_slot() | |
| * Name: i3c_generic_ibi_get_free_slot |
Reference to: https://github.com/torvalds/linux/tree/master/drivers/i3c Signed-off-by: dongjiuzhu1 <[email protected]>
Signed-off-by: yangshuyong <[email protected]>
Only affect the send ccc cmd in 3th driver Signed-off-by: yangshuyong <[email protected]>
Signed-off-by: yangshuyong <[email protected]>
Signed-off-by: yangshuyong <[email protected]>
Signed-off-by: dongjiuzhu1 <[email protected]>
…i2c device 1. if i3c_mater_register without i3c/i2c device, rstdaa/clearevents/do_daa could be failed 2. board code/driver code need to actively i3c_master_do_daa when device power on. Signed-off-by: dongjiuzhu1 <[email protected]>
Signed-off-by: dongjiuzhu1 <[email protected]>
github-actions
bot
added
the
Size: XL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
drivers/i3c: support i3c driver frameworks
The I3C (Improved Inter-Integrated Circuit) driver is a comprehensive software framework designed to support the advanced features of the I3C protocol. It comprises a system framework and underlying IP drivers, both of which are critical components for enabling seamless communication between I3C devices. The system framework, provided by vela os, offers user-level device nodes and kernel-level driver function interfaces. Meanwhile, the underlying IP drivers, developed specifically for the I3C driver framework, handle the implementation of IP functionalities and the adaptation of framework-level interfaces.
Impact
support driver frameworks: i3c
Testing
Vela