-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sched/signal: Simplified Implementation for SIGEV_THREAD_TID #13530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is to make Coverity happy. Signed-off-by: ouyangxiangzhen <[email protected]>
This commit simplified the implementation for SIGEV_THREAD_TID. Signed-off-by: ouyangxiangzhen <[email protected]>
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX requirements. Here's why:
To improve this PR:
|
This commit simplified thread ID dispatching logic by integrating it into the `nxsig_dispatch` function. Signed-off-by: ouyangxiangzhen <[email protected]>
@Fix-Point let's revert the commit 9a9d0a6 too. |
This reverts commit 9a9d0a6.
github-actions
bot
added
Size: S
The size of the change in this PR is small
Area: Board support
Board support issues
Area: OS Components
OS Components issues
labels
Sep 20, 2024
This commit added ifdef macro to sigwork_s. When CONFIG_SIG_EVTHREAD is not defined, the struct sigwork_s will be empty struct, which is helpful to reduce bss size. Signed-off-by: ouyangxiangzhen <[email protected]>
xiaoxiang781216
approved these changes
Sep 23, 2024
anchao
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Board support
Board support issues
Area: OS Components
OS Components issues
Size: S
The size of the change in this PR is small
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit simplified the implementation for SIGEV_THREAD_TID and added the missing siginfo initializer.
Impact
POSIX timer with SIGEV_THREAD_TID flag.
Testing
Tested on QEMU using rt-tests/cyclictest.