Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pci ep framework #13553

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Pci ep framework #13553

wants to merge 5 commits into from
+3,445 −212

Conversation

lipengfei28
Copy link
Contributor

Summary

nuttx add pci ep framework

Impact

Testing

@github-actions github-actions bot added the Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. label Sep 20, 2024
@nuttxpr
Copy link

nuttxpr commented Sep 20, 2024

[Experimental Bot, please feedback here]

Squash The Commits: This PR contains 6 Commits. Please Squash the Multiple Commits into a Single Commit.

No, this PR does not meet the NuttX requirements.

Summary:

  • Insufficient information: The summary is too brief and lacks essential details. It doesn't explain:
    • Necessity: Why is the PCI EP framework needed? What problem does it solve, or what improvement does it bring?
    • Functionality: Which part of the codebase is affected? What specific PCI EP capabilities are being added?
    • Implementation: How does the framework work? What changes have been made to the code?
  • Missing references: Are there related NuttX issues or NuttX Apps issues/pull requests?

Impact:

  • Entirely missing: The impact section is empty. You must address all the points to demonstrate a thorough understanding of your changes.

Testing:

  • No details provided:
    • You need to list the specific build hosts (OS, CPU, compiler) and target devices (architecture, board, configuration) where you tested the changes.
    • Provide actual testing logs from before and after the change to show the difference in behavior.

To improve this PR:

  1. Expand the Summary: Provide a clear and detailed explanation of the changes, their purpose, and how they are implemented.
  2. Complete the Impact section: Analyze and describe the impact of your changes on all the listed aspects (user, build, hardware, documentation, security, compatibility).
  3. Provide Testing Details: Specify your build hosts and target devices, and include relevant testing logs from before and after applying your changes.

By addressing these points, your PR will be far more likely to be reviewed and merged.

lipengfei28 and others added 5 commits September 20, 2024 17:55
@lipengfei28
bits:rename __set_bit to set_bit __clear_bit to clear_bit
5c80cf2 
Signed-off-by: lipengfei28 <[email protected]>
@lipengfei28
libc: add find_next_zero_bit
61405e9 
Signed-off-by: lipengfei28 <[email protected]>
@lipengfei28
math: Optimize the implementation of log2ceil and log2floor
7bb979d 
and move common math funtions to math32.h:
div_round_up
div_round_closest
is_power_of_2
roundup_pow_of_two
rounddown_pow_of_two

Signed-off-by: lipengfei28 <[email protected]>
@lipengfei28
bitmap: add bitmap_find_free_region
3fccc97 
Signed-off-by: lipengfei28 <[email protected]>
@lipengfei28
Support nuttx pci endpoint driver framework
7d96fc5 
Signed-off-by: yangshuyong <[email protected]>
Signed-off-by: lipengfei28 <[email protected]>
jerpelea
jerpelea requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jerpelea jerpelea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fill commit messages that explain the change and the reason why it is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerpelea jerpelea jerpelea requested changes

Assignees
No one assigned
Labels
Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lipengfei28 @nuttxpr @jerpelea