-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riscv: add a return value to riscv_swint #13564
base: master
Are you sure you want to change the base?
Conversation
[Experimental Bot, please feedback here] Yes, the PR appears to meet the NuttX requirements. Here's a breakdown:
Recommendations for Improvement:
Overall: The PR provides a good starting point. Adding the recommended details will ensure a smoother review process and increase the likelihood of a quick merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OSTest seems to hang at vfork() for rv-virt:knsh
? https://gist.github.com/lupyuen/8daee1123a52e222fb601287a00af149
$ git clone https://github.com/hujun260/nuttx --branch apache_10 nuttx
$ tools/configure.sh rv-virt:knsh
...
$ qemu-system-riscv32 -semihosting -M virt,aclint=on -cpu rv32 -kernel nuttx -bios opensbi-1.5-rv-bin/share/opensbi/ilp32/generic/firmware/fw_dynamic.bin -nographic
QEMU emulator version 9.0.2
OpenSBI v1.5
...
nsh> ostest
user_main: vfork() test
[Hangs here]
Update: rv-virt:knsh64
also hangs at vfork(): https://gist.github.com/lupyuen/ce2e2cb328073d25743adbd4bc4a9b87
… switch is required This commit fixes the regression from apache#13561 Signed-off-by: hujun5 <[email protected]>
i fixed this issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OSTest is now OK on rv-virt:knsh, rv-virt:knsh64 and milkv_duos:nsh thanks!
Summary
add a return value to riscv_swint indicating whether a context switch is required
This commit fixes the regression from #13561
Impact
Testing
ostest