mqueue: revert refactor of mqueue

[fdcavalcanti]

Summary

This PR reverts #13413 which refactors mqueue.
The reason for this is that this refactor broke the WiFi CI on both Xtensa and RISC-V Espressif devices.

So far, the following has stopped working across affected SoCs:

• ifconfig after reboot not responding as it used to
• connection to AP using wapi throws many errors and is unstable
• Multiple failures on WiFi performance test using IPERF.

If this affected Espressif devices using those tools, it is possible it affected other devices as well. I'm keeping an eye open on new issues.

Impact

Restores WiFi support on Espressif devices.

Testing

Reverted #13413 on master, run the entire CI and everything works again.

[github-actions]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[github-actions]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[GUIDINGLI]

Hold for some time, and I will give you a different way to handle this issue.

[GUIDINGLI]

@fdcavalcanti
Please, provide how to build, how to execute the bin, how to reproduce the issue.

[GUIDINGLI]

You must give a Qemu ENV which can reproduce this issue

[fdcavalcanti]

Hi @GUIDINGLI. I'll check if QEMU can reproduce this.

Meanwhile, a quick way of viewing the errors:

• Build setup: ./tools/configure.sh esp32-devkitc:sta_softap
• Set CONFIG_DEBUG_FEATURES, CONFIG_DEBUG_NET, CONFIG_DEBUG_NET_ERROR, CONFIG_DEBUG_NET_WARN, CONFIG_DEBUG_WIRELESS, CONFIG_DEBUG_WIRELESS_ERROR, CONFIG_DEBUG_WIRELESS_WARN
• Build and flash.

Run wapi scan wlan0 a couple of times and it stops responding.

[fdcavalcanti]

Hold for some time, and I will give you a different way to handle this issue.

What's your plan here?

[GUIDINGLI]

Hold for some time, and I will give you a different way to handle this issue.

What's your plan here?

Sorry, don't have esp32 env current now.
Can reproduce on Qemu? If so, that will be very helpful for this issue

[GUIDINGLI]

@fdcavalcanti

Please see:
#13841

The rootcause is not mq's refactor, but there already has a bug on esp32 time calculation.
One suggestion, if you meet a question, try to fix the bug first time.

[GUIDINGLI]

@fdcavalcanti
You can close this PR now.

[fdcavalcanti]

@GUIDINGLI thank you for the fix.
I hope you did not take this personally. Sorry about the confusion around this issue.

[fdcavalcanti]

Please let's stand by on this.
Don't know what gave the impression that PR should be merged but the proposed fix did not work and we have WiFi still failing across all devices. Still looking into it.

[xiaoxiang781216]

@GUIDINGLI thank you for the fix.

Sorry, from this reply, I think you verify that #13841 fix your problem.

[GUIDINGLI]

Please let's stand by on this. Don't know what gave the impression that PR should be merged but the proposed fix did not work and we have WiFi still failing across all devices. Still looking into it.

I have reproduce your issue through a real esp32.
compile:
boards/risc-v/esp32c3/esp32c3-generic/configs/wifi
make flash

Run wapi scan wlan0 cmd a couple of times and it stops responding.

Then add patch #13841, and re-compile a re-run.
The problem was gone.

If you still have questions, you can deep into the program to find the rootcause.