Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/arm64/imx9/imx93-evk: add trdc header #14687

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

joukkone
Copy link
Contributor

@joukkone joukkone commented Nov 7, 2024

Example trdc header for bootloader build

This is needed when building bootloader for imx9-evk

Note: Please adhere to Contributing Guidelines.

Summary

Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.

Impact

Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.

Testing

Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.

@github-actions github-actions bot added Board: arm64 Size: M The size of the change in this PR is medium labels Nov 7, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 7, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements. While it provides the template, it lacks the crucial information required by the template. Specifically, the sections marked with "Update this section..." are placeholders and haven't been filled with the actual details of the change. A PR with these placeholders is incomplete and unreviewable.

Here's a breakdown of what's missing:

  • Summary: The summary needs to explain the why, what, and how of the change. It mentions a trdc header for the imx9-evk bootloader, but doesn't explain why this header is needed, what it contains, or how it solves the problem. There's no mention of related issues.

  • Impact: All the impact fields are left blank. The author needs to assess and document the impact of the change on users, build process, hardware, documentation, security, and compatibility.

  • Testing: The testing section is also incomplete. It requests details about the build host and target, as well as logs from before and after the change, but none of this information is provided. Simply stating "This is needed" isn't sufficient verification.

To meet the NuttX requirements, the author needs to fill out all the required sections with specific information relevant to the changes made.

@acassis
Copy link
Contributor

acassis commented Nov 7, 2024

Hi @joukkone nice contribution! Please include later a board config and a Documentation/ explaining how to use the bootloader on this board

@github-actions github-actions bot added Arch: arm64 Issues related to ARM64 (64-bit) architecture Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces. and removed Size: M The size of the change in this PR is medium labels Nov 11, 2024
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@joukkone
Copy link
Contributor Author

Updated patch. There is now full trdc configuration, Those header files can be generated with that nxp chiptool, Trdc configuration must be done before DDR configuration. Final configuration should be executed just before jumping to EL1.

arch/arm64/src/imx9/hardware/imx9_trdc.h Outdated Show resolved Hide resolved
arch/arm64/src/imx9/imx9_trdc.c Outdated Show resolved Hide resolved
arch/arm64/src/imx9/imx9_trdc.c Outdated Show resolved Hide resolved
arch/arm64/src/imx9/imx9_trdc.c Show resolved Hide resolved
arch/arm64/src/imx9/imx9_trdc.c Outdated Show resolved Hide resolved
arch/arm64/src/imx9/imx9_trdc.c Outdated Show resolved Hide resolved
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

arch/arm64/src/imx9/imx9_trdc.c Outdated Show resolved Hide resolved

/* Bits 8:15 rdc id, bits 0:7 core id */

#define TRDC_AON 0x7402
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align ALL second column

#define ELE_MU_TR(i) (IMX9_S3MUA_BASE + 0x200 + (i) * 4)
#define ELE_MU_RR(i) (IMX9_S3MUA_BASE + 0x280 + (i) * 4)

#define DID_NUM 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align ALL second column to the same position

#define AHAB_CMD_TAG 0x17
#define AHAB_RESP_TAG 0xe1
#define ELE_RELEASE_RDC_REQ 0xc4
#define ELE_READ_FUSE_REQ 0x97
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@xiaoxiang781216
Copy link
Contributor

@joukkone let's squash the patch into one.

Trdc is configured in EL3 bootloader
Clock pre-initialization is also executed there.
Trdc board configuration for imx93evk included

Signed-off-by: Jouni Ukkonen <[email protected]>
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@xiaoxiang781216 xiaoxiang781216 merged commit e2a9c84 into apache:master Nov 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: arm64 Issues related to ARM64 (64-bit) architecture Board: arm64 Size: XL The size of the change in this PR is very large. Consider breaking down the PR into smaller pieces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants