-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/arm64/imx9/imx93-evk: add trdc header #14687
boards/arm64/imx9/imx93-evk: add trdc header #14687
Conversation
[Experimental Bot, please feedback here] No, this PR does not meet the NuttX requirements. While it provides the template, it lacks the crucial information required by the template. Specifically, the sections marked with "Update this section..." are placeholders and haven't been filled with the actual details of the change. A PR with these placeholders is incomplete and unreviewable. Here's a breakdown of what's missing:
To meet the NuttX requirements, the author needs to fill out all the required sections with specific information relevant to the changes made. |
Hi @joukkone nice contribution! Please include later a board config and a Documentation/ explaining how to use the bootloader on this board |
1c016ec
to
3c7029a
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Updated patch. There is now full trdc configuration, Those header files can be generated with that nxp chiptool, Trdc configuration must be done before DDR configuration. Final configuration should be executed just before jumping to EL1. |
3c7029a
to
e159724
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
||
/* Bits 8:15 rdc id, bits 0:7 core id */ | ||
|
||
#define TRDC_AON 0x7402 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
align ALL second column
#define ELE_MU_TR(i) (IMX9_S3MUA_BASE + 0x200 + (i) * 4) | ||
#define ELE_MU_RR(i) (IMX9_S3MUA_BASE + 0x280 + (i) * 4) | ||
|
||
#define DID_NUM 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
align ALL second column to the same position
#define AHAB_CMD_TAG 0x17 | ||
#define AHAB_RESP_TAG 0xe1 | ||
#define ELE_RELEASE_RDC_REQ 0xc4 | ||
#define ELE_READ_FUSE_REQ 0x97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@joukkone let's squash the patch into one. |
Trdc is configured in EL3 bootloader Clock pre-initialization is also executed there. Trdc board configuration for imx93evk included Signed-off-by: Jouni Ukkonen <[email protected]>
e159724
to
b12f37d
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Example trdc header for bootloader build
This is needed when building bootloader for imx9-evk
Note: Please adhere to Contributing Guidelines.
Summary
Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.
Impact
Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.
Testing
Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.