GreenHills support: fix the naked_function attr cannot handle warning with old version GHS compiler #14719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: OS Components
xiaoxiang781216
approved these changes
Nov 11, 2024
anchao
requested changes
Nov 11, 2024
with greenhills version older than 202354, the __attribute__((naked)) cannot handled by greenhills compiler, and will report warning: "/home/guoshichao/work_profile/vela_os/vela_car_6/nuttx/arch/arm/src/armv7-m/arm_svcall.c", line 79: warning apache#1097-D: unknown attribute "naked" static void dispatch_syscall(void) naked_function; ^ Signed-off-by: guoshichao <[email protected]>
extinguish
force-pushed
the
ghs_naked_func_warning
branch
from
0bf1a01
to
33e0869
Compare
anchao
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With greenhills version older than 202354, the attribute((naked)) cannot handled by greenhills compiler, and will report warning:
We need to ignore these warning when we build with old version GHS compiler
Impact
Has no impact on other toolchain
Testing