Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esp32c6 pm rebased squashed #14726

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FelipeMdeO
Copy link
Contributor

Note: Please adhere to Contributing Guidelines.

Summary

Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.

Impact

Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.

Testing

Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.

Fix build issues

Esp Low Power Mode Basic Implementation Done

Added spi slave wakeup from cs pin

Change flow to use dedicated pin to wakeup mcu.

Added pm lock logic

Remove some build warnings

Update Kconfig to enable auto sleep

wip

minor fixes

fix build issues
recovery changes

wip

wip
@github-actions github-actions bot added Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Board: risc-v Size: L The size of the change in this PR is large labels Nov 11, 2024
@nuttxpr
Copy link

nuttxpr commented Nov 11, 2024

[Experimental Bot, please feedback here]

Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.

This PR template itself meets the NuttX requirements by providing the necessary sections and prompting the contributor to fill them with specific information. However, a PR is only complete and meets requirements when a developer provides the required details within each section. A blank template PR would not meet the requirements.

Specifically, the template addresses the requirements by:

Summary: It directly asks for the reason for the change, what part of the code is affected, how the change works, and links to related issues.

Impact: It explicitly requires the contributor to address the impact on users, build, hardware, documentation, security, and compatibility.

Testing: It mandates information on the build host, target platform, and testing logs before and after the change, promoting thorough verification and providing evidence of the change's effectiveness.

By requiring these details, the template ensures that contributors consider all aspects of their changes and provide enough information for reviewers to effectively evaluate the PR. It encourages best practices and helps maintain the quality and stability of the NuttX project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Board: risc-v Size: L The size of the change in this PR is large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants