Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improved: Prevent URL parameters manipulation (OFBIZ-13147)
The "JavaScriptEnabled=Y" and "&wt=javabin" references are weaknesses. I temporarily put them in ControlFilter::doFilter to allow things (demo and integration tests) to work for my test (only possible on a site w. domain IP), ie not locally. I think we can remove "JavaScriptEnabled=Y". I put it there because we use it in links at https://ofbiz.apache.org/ofbiz-demos.html. Maybe other places where it's easy to remove w/o side effects. It's anyway an user preference, not mandatory in query string. I needed "&wt=javabin" for the Solr tests to pass. Sometimes ago I already faced a such issue. And then put in place what's needed. ControlFilter::isSolrTest is the solution by generalising this usage.
- Loading branch information