Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Slim down use of ${groovy: } (OFBIZ-13146) #838

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

nmalin
Copy link
Contributor

@nmalin nmalin commented Oct 8, 2024

Improved: Slim down use of ${groovy: } (OFBIZ-13146)

With the framework evolution, we used on many place the scriptlet ${groovy: } on screen rendering where something it's now unecessary.

This issue convert some of them on a other solution to slim down this usage

@JacquesLeRoux
Copy link
Contributor

JacquesLeRoux commented Oct 8, 2024

Hi @nmalin,

Thanks for the good work (tested on Flat Grey for "---------- Last system notes ----------")

Should the file
framework/common/src/main/groovy/org/apache/ofbiz/common/GetUiLables.groovy
not be named
framework/common/src/main/groovy/org/apache/ofbiz/common/GetUiLabels.groovy ;)

@nmalin
Copy link
Contributor Author

nmalin commented Oct 8, 2024

Thanks Jacques I'll have a look to many change on many subject :D

With the framework evolution, we used on many place the scriptlet ${groovy: } on screen rendering where something it's now unecessary.

This issue convert some of them on a other solution to slim down this usage
@nmalin nmalin force-pushed the OFBIZ-13146-slimdown-scripting-groovy branch from aac2d3a to 4d4df9d Compare October 25, 2024 09:39
Copy link

sonarcloud bot commented Nov 5, 2024

@nmalin nmalin merged commit 10529c3 into apache:trunk Nov 5, 2024
6 checks passed
nmalin added a commit that referenced this pull request Nov 5, 2024
* Improved: Slim down use of ${groovy: } (OFBIZ-13146)

With the framework evolution, we used on many place the scriptlet ${groovy: } on screen rendering where something it's now unecessary.

This issue convert some of them on a other solution to slim down this usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants