Improved: Truncate encoded string (OFBIZ-13167) #844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On model form, when you use a field description with a text size like :
and your field myField contains a string with a special character like "my char é, so bad truncate", the widget rendering displays "my char &e..." because when truncate is executed, the string is encoded and some chars are encoded : "my char &eacut;, so bad truncate".
The size between the encoded string and the displayed string are different. So to fix this, we implemented a new method to truncate the content. This method identify each special char as one char, and truncate.
"my char é, so bad truncate" encoded to "my char &eacut;, so bad truncate" become "my char &eacut;..." and not "my char &e..."
Thanks: Charles Steltzlen who help to solve it