feat(bindings/ruby): Add simple operators to Ruby binding #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ruby 3.0 is EoL. Since OpenDAL gem is fresh new, use 3.1 and up - Use a Ruby with rubygems that can compile Rust gem
- create_dir - delete - exist? - rename - remove_all - copy Also refactor tests with Ruby stdlib
erickguan
force-pushed
the
ruby-binding
branch
from
1e6d637
to
efe2e27
Compare
Xuanwo
reviewed
Nov 5, 2024
bindings/ruby/src/operator.rs
Outdated
| #[derive(Clone, Debug)] | ||
| struct Operator(ocore::BlockingOperator); | ||
|
|
||
| fn format_magnus_error(err: ocore::Error) -> Error { |
Xuanwo
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Thank you @erickguan for this PR! The ruby binding finally got some love.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5227.
Rationale for this change
I would suggest to review this commit by commit. I also noticed the options to initialize
Operatorcan only be a dictionary. Keyword arguments would be better.