-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Maven/Java Tooling #113
base: master
Are you sure you want to change the base?
Conversation
… parent is released
…iggers don't support updates if not existing and removed the package option from triggers and rules
@klcodanr this looks really nice. One thought I have is regarding the deploy process. Are you familiar with wskdeploy ? It has more logic to deploy, update, delete, remove what's changed, etc. I'm wondering if it would be a cleaner approach if we were to use the Java Annotations to generate a cc @mrutkows |
@kameshsampath @gorkem may I ask for your help reviewing this PR, since you made the initial java contributions ? |
@ddragosd sure, looking at it |
So I looked into wskdeploy, looks like a really nice toolset. I was wondering how it would handle if you wanted one or more modules to contribute to a single package? I'm thinking of a case where you'd have some pretty significant dependencies for a set of actions which you don't want to bloat other actions with. The best solution to me would be to support two different mojos:
so your project could look something like:
The artifact for module 3 can then be a ZIP file containing the manifest YAML and all of the previous artifacts required to build it. |
@klcodanr I do not see any namespace support on the mojo. Is that by design? This will require CI systems to do extra steps to deploy to a certain namespace. Also mojo is using the CLI but have you considered using the APIs directly instead of the CLI? I think it would make it more intuitive to use on CI systems. |
Namespace - good point, I missed that, I'll add it as a Mojo parameter |
The namespace is usually implied by the auth key - you shouldn’t have a single key with more than one namespace associated with it. |
@klcodanr your proposal SGTM |
I added some new features to improve the Java tooling for OpenWhisk:
I provided some documentation and reorganized the repo a bit to group the Java dev tools.