HDDS-11388. Fix unnecessary call to the DB for ContainerBalancer#getB…

…alancerStatusInfo
apache · Sep 20, 2024 · ca2438e · ca2438e
1 parent 40c4001
commit ca2438e
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/...er-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java b/...er-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
@@ -183,17 +183,19 @@ public ContainerBalancerTask.Status getBalancerStatus() {
    * @return balancer status info if balancer started
    */
   public ContainerBalancerStatusInfo getBalancerStatusInfo() throws IOException {
-    if (isBalancerRunning()) {
-      ContainerBalancerConfigurationProto configProto = readConfiguration(ContainerBalancerConfigurationProto.class);
-      return new ContainerBalancerStatusInfo(
-              this.startedAt,
-              configProto,
-              task.getCurrentIterationsStatistic()
-      );
-    } else {
+    lock.lock();
+    try {
+      if (isBalancerRunning()) {
+        return new ContainerBalancerStatusInfo(
+            this.startedAt,
+            config.toProtobufBuilder().build(),
+            task.getCurrentIterationsStatistic()
+        );
+      }
       return null;
+    } finally {
+      lock.unlock();
     }
-
   }
   /**
    * Checks if ContainerBalancer is in valid state to call stop.