-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-11450. Avoid managing versions for transitive-only dependencies #7190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
added
build
Pull request that modifies the build process
dependencies
Pull requests that update a dependency file
labels
Sep 12, 2024
… as it could be disabled manually...
adoroszlai
requested review from
kerneltime,
dombizita,
hemantk-12 and
swamirishi
and removed request for
dombizita
September 12, 2024 15:23
Additionally, we could also get rid of the dependency convergence check to avoid the need for exclusions (see adoroszlai@bba79f2). |
Extracted part of this to #7325. |
I plan to create separate PR for each dependency for easier review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Pull request that modifies the build process
dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ozone should not override version of transitive dependencies which are not used directly. E.g.
re2j
via Hadoop, is only used by Hadoop. Bumping its version in Ozone may cause incompatibilities at runtime.Currently:
share/ozone/lib
directory when building theozone-dist
module. It depends on all other Ozone modules directly or transitively. Sinceozone-dist
is a single module, third-party transitive dependency versions are resolved by Maven to a single version. Only that version is copied toshare/ozone/lib
. However, various Ozone components may depend on different versions of the same third-party module. These different versions can end up in the classpath files, but will not be found at runtime.Both of these could result in incompatibilities, which may go unnoticed in CI.
This PR proposes to:
dist-layout-stitching
copies dependencies from per-module directories to the final location when buildingozone-dist
.Dependency changes:
https://issues.apache.org/jira/browse/HDDS-11450
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/10825596616