HDDS-11388. Fix unnecessary call to the DB for ContainerBalancer#getBalancerStatusInfo #7224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alancerStatusInfo
|
Seems container balancer acceptance test failed after this patch. Let me take a look first. Edit: This is because |
|
@ivandika3 let me know when it's ready for review. |
|
@siddhantsangwan Hi, this patch is ready for review. Thank you. |
There was a problem hiding this comment.
This is because shouldRun is not set in the in-memory ContainerBalancerConfigurationProto causing proto exception.
@ivandika3 good find there. This patch looks good. There's a conflict with testBalancer.robot that needs to be fixed.
# Conflicts: # hadoop-ozone/dist/src/main/smoketest/balancer/testBalancer.robot
siddhantsangwan
approved these changes
Oct 24, 2024
|
Thank you for the review @siddhantsangwan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ContainerBalancer#getBalancerStatusInfocan get the current running balancer configuration from the in-memory configuration, which is in sync with the backing DB. Also added lock ingetBalancerStatusInfo.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11388
How was this patch tested?
Unit test.