HDDS-11127. [hsync] Improve test coverage for XceiverClientRatis.java #7225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
According to SonarCloud the new code added to this file is not covered by tests:
https://sonarcloud.io/component_measures?id=hadoop-ozone&branch=HDDS-7593&metric=new_coverage&selected=hadoop-ozone%3Ahadoop-hdds%2Fclient%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhadoop%2Fhdds%2Fscm%2FXceiverClientRatis.java
Please describe your PR in detail:
There are tests (TestCommitInRatis.java and TestWatchForCommit.java) in
org.apache.hadoop.ozone.client.rpctesting the 2 way and 3 way commit in Ratis. I think they are in a wrong place, moving them toorg.apache.hadoop.hdds.scmto cover lines in XceiverClientRatis.java.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11127
How was this patch tested?
CI:
https://github.com/chungen0126/ozone/actions/runs/10970102371