Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spark] Support scala 2.13 #4302

Merged
merged 2 commits into from
Oct 12, 2024
Merged

[spark] Support scala 2.13 #4302

merged 2 commits into from
Oct 12, 2024

Conversation

Zouxxyy
Copy link
Contributor

@Zouxxyy Zouxxyy commented Oct 10, 2024 •
edited
Loading

Purpose

Prepare for #3940

  • Support scala 2.13
    • Ensure that the same code can be compiled in Scala 2.12 and Scala 2.13, the most noteworthy thing is that: we can not use scala.jdk.CollectionConverters (for compatibility with Scala 2.12), we can only use scala.collection.JavaConverters, and need to manually specify the output type (for compatibility with Scala 2.13) such as JList.asScala.toSeq
    • new profile -Pscala-2.13 to change to Scala2.13, default is still Scala2.12
  • Introduce utitcase-spark and utitcase-spark-scala2.13 CI

Tests

API and Format

Documentation

@Zouxxyy Zouxxyy changed the title [WIP][spark] Support scala 2.13 [spark] Support scala 2.13 Oct 11, 2024
@YannByron
Copy link
Contributor

LGTM. @JingsongLi please take a look.

JingsongLi
JingsongLi approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 82abc21 into apache:master Oct 12, 2024
12 checks passed
@Zouxxyy Zouxxyy deleted the dev/scala213 branch October 12, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zouxxyy @YannByron @JingsongLi