-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add flatmapConcat with parallelism support #1702
base: main
Are you sure you want to change the base?
Conversation
77ac9a1
to
4b92618
Compare
I hate 2.12.x |
I wonder if it is really necessary, wouldn't it be easier to just prematerialize to get the same effect? |
Yes, but I think it would be nice to have this out of box. otherwise will need a |
@gael-ft would you take a look at this, thanks. |
@pjfanning @raboof @jrudolph @mdedetrich Would you like to give this some care:) |
4b92618
to
b105a79
Compare
Would anyone like to review this, thanks :) |
import pekko.stream.testkit.{ ScriptedTest, StreamSpec } | ||
import pekko.stream.testkit.scaladsl.TestSink | ||
|
||
import java.util.Collections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you keep the java imports together?
FlattenConcatLogic | ||
} | ||
|
||
override def toString: String = s"FlattenConcat($parallelism)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
override def toString: String = s"FlattenConcat($parallelism)" | |
override def toString: String = s"FlattenConcat(parallelism=$parallelism)" |
Motivation:
Add support for #1672
Based on: #1701
Modification:
Result:
Benchmark: