Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Handle NormalShutdownReason in MergeHub #1741

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Jan 24, 2025

Motivation:
Fix #1739
as anpin just did。

Modification:
Handle the NormalShutdownReason as a normal complementation.

@He-Pin He-Pin marked this pull request as ready for review February 23, 2025 09:01
@He-Pin He-Pin added this to the 1.2.0-M2 milestone Mar 3, 2025
Copy link

@danischroeter danischroeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit ba05791 into apache:main Mar 3, 2025
9 checks passed
@He-Pin He-Pin deleted the mergehub branch March 3, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete MergeHub Sink gracefully on NormalShutdownException
3 participants