-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch to new new wildcard [?]. #971
base: main
Are you sure you want to change the base?
Conversation
Will need another ignore blame, if this can get merged. |
So I am a bit on the fence of this, mainly because its such a massive rewrite that its going to cause quite a bit of chaos especially with the amount of open PR's we have. I would be more amicable to it if we only rewrote scala-3 sources rather than the entire project. Another disadvantage is that it will make backports to I am not against it, but there might be better timing to merge such a PR (i.e. when there are very few open PR's). Curious to hear what others think. Would also like to see the response from VirtusLab/scala-cli#2684 |
?
.
If I compile it with Scala 3.4, there will be many warning, I want our code prepare for the next LTS early, at least seems not that harm, and in Java we use |
Thanks for providing the context, then I would initially suggest lets wait until Pekko 1.1.0 is out and some more PR's are merged, Scala 3.5.x LTS is still a long way off. |
@mdedetrich another case why I want pekko code to be more scala 3.4 friendly |
This appears to be entirely unrelated and type inferencer/compiler bug, not syntax. |
Motivation:
Test and migrate code to use
?
.known issue: VirtusLab/scala-cli#2684
Note: this pr is for testing
background: #878