Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix FlowCollectWhileSpec. #985

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Jan 19, 2024

Motivation:
Fix typo in the collectwhileSpec, where shuld be collect.

@He-Pin He-Pin added the t:stream Pekko Streams label Jan 19, 2024
@He-Pin He-Pin requested a review from pjfanning January 19, 2024 16:46
Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He-Pin He-Pin changed the title chore: Fix typo in collectWhile spec. chore: Fix FlowCollectWhileSpec. Jan 19, 2024
@He-Pin
Copy link
Member Author

He-Pin commented Jan 19, 2024

@pjfanning I have updated the title, and will not update it further, the GFW blocked me, I can't push any thing.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit b1ec854 into apache:main Jan 19, 2024
18 checks passed
@He-Pin He-Pin deleted the collectWhileSpec branch January 19, 2024 21:02
@pjfanning
Copy link
Contributor

@He-Pin could you backport this to 1.0.x branch?

@He-Pin
Copy link
Member Author

He-Pin commented Jan 19, 2024

@pjfanning There is no FlowCollect in 1.0.x :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:stream Pekko Streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants