PHOENIX-7381 : Skip last_ddl_timestamp validation when UCF is defined on table and cache entry is not old #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajjasani
reviewed
Aug 13, 2024
Comment on lines
+1850
to
+1853
| assertEquals("There should have been no timestamp validation requests.", | ||
| 0, | ||
| newMetricValues.getValidateDDLTimestampRequestsCount() | ||
| - oldMetricValues.getValidateDDLTimestampRequestsCount()); |
There was a problem hiding this comment.
newMetricValues.getValidateDDLTimestampRequestsCount() should also be 0?
There was a problem hiding this comment.
There will be requests from other tests, that's why I am checking the difference before and after just this test.
|
@virajjasani Does this change look good? If yes, we can get it in. |
virajjasani
reviewed
Sep 30, 2024
phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
Outdated
Show resolved
Hide resolved
| @@ -40,7 +40,7 @@ private static void initCluster() throws Exception { | |||
| Map<String, String> props = Maps.newConcurrentMap(); | |||
| props.put(BaseScannerRegionObserverConstants.PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY, | |||
| Integer.toString(60 * 60 * 1000)); | |||
| props.put(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, "ALWAYS"); | |||
| props.put(QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, "NEVER"); | |||
There was a problem hiding this comment.
do we want to test with both ALWAYS and NEVER?
There was a problem hiding this comment.
@virajjasani With DDL timestamp validation, UCF should not be ALWAYS, so I think it is okay. WDYT?
virajjasani
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.