Change XWPFDocument#getNextPicNameNumber slot selection implementation#194
Open
MariusVolkhart wants to merge 1 commit intoapache:trunkfrom
Open
Change XWPFDocument#getNextPicNameNumber slot selection implementation#194MariusVolkhart wants to merge 1 commit intoapache:trunkfrom
MariusVolkhart wants to merge 1 commit intoapache:trunkfrom
Conversation
Previously, the implementation would result in a slot that was greater than the total count of pictures in the document and was available. For example, a document that had [1.png, 3.jpeg] would get a slot of 4, regardless of the format. The new implementation gives the first slot that is available for the specific format. That same document of [1.png, 3.jpeg] will now issue slot 2 for a PNG and slot 1 for a JPEG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the implementation would result in a slot that was greater than the total count of pictures in the document and was available. For example, a document that had [1.png, 3.jpeg] would get a slot of 4, regardless of the format.
The new implementation gives the first slot that is available for the specific format. That same document of [1.png, 3.jpeg] will now issue slot 2 for a PNG and slot 1 for a JPEG.