Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for Proxy configuration when using Polaris CLI #1113

Open
sfc-gh-spatel2 opened this issue Mar 5, 2025 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@sfc-gh-spatel2
Copy link

Is your feature request related to a problem? Please describe.

The Polaris CLi is obtaiend and executed as follows:
git clone https://github.com/apache/polaris.git

cd polaris

./polaris
--base-url "${base_url}/polaris"
--client-id ${CLIENT_ID}
--client-secret ${CLIENT_SECRET}
catalogs
update "${catalogName}"
--region us-west-1

Some customers are behind a proxy and are not able to use this command.

Tested with export HTTPS_PROXY and HTTP_PROXY. but it does not pick this up.
The request fails and does not go through the proxy

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@sfc-gh-spatel2 sfc-gh-spatel2 added the enhancement New feature or request label Mar 5, 2025
@MonkeyCanCode
Copy link
Contributor

So currently the code doesn't allow proxy option to be pass in. I can add this support if there is no concern? I am able to build a local POC setup for this.
@flyrain @eric-maynard @HonahX

@MonkeyCanCode
Copy link
Contributor

Sample PR for this request in case if we would want to support: #1115

Also, @sfc-gh-spatel2 can you check if that is what you are looking for and test with more proper setup?

@MonkeyCanCode
Copy link
Contributor

@sfc-gh-spatel2 the above PR is merged. Please run your test to see if this fixed the problem you were facing before I close this one.

@MonkeyCanCode MonkeyCanCode self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants