Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy option for CLI #1115

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Conversation

MonkeyCanCode
Copy link
Contributor

This feature is requested from #1113. Currently we don't support pass in proxy info.

Here is how this PR is being validated:
Terminal 1:

# Setup mitmproxy
(venv) yong@DESKTOP:~/k8s/polaris(main)$ pip install mitmproxy
# Start mitmproxy
(venv) yong@DESKTOP:~/k8s/polaris(proxy_support)$ mitmproxy

Terminal 2:

# Start polaris service
yong@DESKTOP:~/k8s/polaris(main)$ ./gradlew run

Terminal 3:

# List catalog without proxy
yong@DESKTOP:~/k8s/polaris(proxy_support)$ ./polaris --profile dev catalogs list
yong@DESKTOP:~/k8s/polaris(proxy_support)$ echo $?
0
# List catalog with proxy
yong@DESKTOP:~/k8s/polaris(proxy_support)$ ./polaris --profile dev --proxy http://localhost:8080 catalogs list
yong@DESKTOP:~/k8s/polaris(proxy_support)$ echo $?
0

Now here is the output from terminal 1:
image

@eric-maynard eric-maynard merged commit 72b14cb into apache:main Mar 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants