Build: Add pom.xml, pom.properties and LICENSE+NOTICE to release jars
#1036
Conversation
snazy
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
| inputs.property("GAV", "${project.group}:${project.name}:${project.version}") | ||
| dependsOn("generatePomFileForMavenPublication") | ||
| from(rootProject.rootDir) { | ||
| include("LICENSE", "NOTICE") |
There was a problem hiding this comment.
I'm not sure about including the root NOTICE into each jar. Binary notices may have to be different for different jars because of different dependency sets.
@jbonofre : WDYT?
There was a problem hiding this comment.
It's all we have at the moment. 🤷
There was a problem hiding this comment.
Theorically, we should have LICENSE/NOTICE actually representing what's in the jar. Taking LICENSE/NOTICE from the root folder (e.g. source distribution) is fine.
I'm working on LICENSE/NOTICE for uber jars/distributions (see #1031 ).
So let me do a pass, but using LICENSE/NOTICE sounds reassonoable.
There was a problem hiding this comment.
I still do not see the benefit of including the root NOTICE in every jar (due to it not being 100% correct) but I'll defer to @jbonofre 's opinion.
…jars Adds convenient, but not strictly necessary information to each generated "main" jar. This includes `pom.properties` and `pom.xml` files where Maven places those, in `META-INF/maven/group-id/artifact-id/`. Also adds the `NOTICE` and `LICENSE` files in `META-INF`, which makes it easier for license scanners.
Adds convenient, but not strictly necessary information to each generated "main" jar.
This includes
pom.propertiesandpom.xmlfiles where Maven places those, inMETA-INF/maven/group-id/artifact-id/. Also adds theNOTICEandLICENSEfiles inMETA-INF, which makes it easier for license scanners.