-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for Python client #1096
Open
DaniilRoman
wants to merge
7
commits into
apache:main
Choose a base branch
from
DaniilRoman:1058-add-ci-for-python-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add CI for Python client #1096
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9861bd8
Add CI for Python client
DaniilRoman 389f5e6
Increase actions cache version
DaniilRoman 210b285
Get use of working-directory
DaniilRoman 98b2078
Add EOF line
DaniilRoman 5a5c0a5
Install Poetry 1.8.5 + remove 3.7, 3.8 Python versions from matrix
DaniilRoman c7e8ec5
Set SCRIPT_DIR before running pytest
DaniilRoman a4d6351
Relax flake8 rules
DaniilRoman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
# | ||
|
||
# This workflow uses actions that are not certified by GitHub. | ||
# They are provided by a third-party and are governed by | ||
# separate terms of service, privacy policy, and support | ||
# documentation. | ||
# This workflow will build a Python project with Poetry and cache/restore any dependencies to improve the workflow execution time | ||
# For more information see: https://docs.github.com/en/actions/use-cases-and-examples/building-and-testing/building-and-testing-python | ||
|
||
name: Python CI with Poetry | ||
|
||
on: | ||
push: | ||
branches: [ "main" ] | ||
paths: | ||
- 'regtests/client/python/**' | ||
pull_request: | ||
branches: [ "main" ] | ||
paths: | ||
- 'regtests/client/python/**' | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
python-version: ["3.9", "3.10", "3.11"] | ||
|
||
steps: | ||
- name: Checkout Polaris project | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Cache Poetry | ||
id: cache-poetry | ||
uses: actions/cache@v4 | ||
with: | ||
path: ~/.cache/pypoetry | ||
key: ${{ runner.os }}-poetry-${{ hashFiles('regtests/client/python/poetry.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-poetry- | ||
|
||
- name: Install Poetry | ||
if: steps.cache-poetry.outputs.cache-hit != 'true' | ||
run: | | ||
curl -sSL https://install.python-poetry.org | python3 - --version 1.8.5 | ||
export PATH="$HOME/.local/bin:$PATH" | ||
|
||
- name: Install dependencies | ||
working-directory: regtests/client/python | ||
run: poetry install | ||
|
||
- name: Lint with flake8 | ||
working-directory: regtests/client/python | ||
run: | | ||
poetry run flake8 --select=E9,F63,F7,F82 --max-line-length=127 --statistics | ||
|
||
- name: Test with pytest | ||
working-directory: regtests/client/python | ||
run: | | ||
export SCRIPT_DIR="non-existing-mock-directory" | ||
poetry run pytest |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it was nicely noticed in the related PR here #1102 (comment)
This line will cause failure since
poetry.lock
is in.gitignore
I'd duplicate my question here as well
If we had
poetry.lock
we could even use this config cache: 'poetry' of actions/setup-python@v5 GitHub action (here's this docs section).Without having
poetry.lock
we can only cache based onpyptoject.toml
which doesn't cover transitive dependencies.I've also thought about generating
poetry.lock
on CI but for this we need to have poetry first and when we install poetry, it installs dependencies as well - so, it wouldn't workWhat about removing
poetry.lock
from.gitignore
and creating it and managing for the future changes? 🤔Or is it good enough to create a hash key based on
myproject.toml
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment for this in the other PR.