Upgrade Iceberg to 1.8 #1126
Open
Upgrade Iceberg to 1.8 #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamzwbao
commented
Mar 6, 2025
| @@ -215,6 +215,10 @@ public void initialize(String name, Map<String, String> properties) { | |||
| name, | |||
| this.catalogName); | |||
|
|
|||
| // Ensure catalogProperties is assigned before calling metricsReporter() for proper | |||
| // functionality. | |||
| catalogProperties = properties; | |||
There was a problem hiding this comment.
This fixes testCatalogWithCustomMetricsReporter
liamzwbao
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
ebyhr
reviewed
Mar 6, 2025
gradle/libs.versions.toml
Outdated
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| [versions] | |||
| hadoop = "3.4.1" | |||
| iceberg = "1.7.1" | |||
| iceberg = "1.8.0" | |||
There was a problem hiding this comment.
Could you let me know why you avoided 1.8.1? There are some regressions in 1.8.0.
There was a problem hiding this comment.
Just noticed 1.8.1 is available, upgraded. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TableMetadata.addSchemamethodENDPOINTSinIcebergCatalogAdapterinitCatalogmethod inCatalogTestsPolarisRestCatalogIntegrationTestandBasePolarisCatalogTestdue to:Assumptions.assertThatof AssertJ, used inCatalogTestsin Iceberg, is incompatible with Quarkus, see Support Assumptions.assumeThat in Quarkus quarkusio/quarkus#46642.listNamespacesWithEmptyNamespace. Consider whether to align this behavior.createViewWithCustomMetadataLocationinQuarkusRestCatalogViewFileITandQuarkusRestCatalogViewFileIntegrationTestby ensuring that thetempDirremains withinBASE_LOCATION.write.metadata.pathtoAllowedLocationsinBasePolarisCatalogViewBuilderwhen specified by the user, similar to Add support for customer write.data.path and write.metadata.path with test for object store location provider #193.