Allow MetaStore manager to declare whether bulk reload is necessary #1132
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is in anticipation of NoSQL persistence implementations. A MetaStore manager does not have to use entity caching and provide fresh results from all load method, thus making the `bulkValidate` call redundant in `Resolver`. This change does not alter existing behaviour, but enables future optimizations. Co-authored-by: Robert Stupp <[email protected]>
dimas-b
requested review from
adutra,
ashvina,
dennishuo,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain and
ebyhr
as code owners
eric-maynard
reviewed
Mar 7, 2025
Comment on lines
+386
to
+388
| default boolean requiresEntityReload() { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Based on the comment, I wonder if we could just use cache == null?
There was a problem hiding this comment.
That's what it looks like to me too, but I'd like to allow implementations to make this decision separately. We can revisit and remove this method when a NoSQL impl. is make available for review (if it happens to be redundat)... but so far it seems useful for our WIP code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in anticipation of NoSQL persistence implementations.
A MetaStore manager does not have to use entity caching and provide fresh results from all load method, thus making the
bulkValidatecall redundant inResolver.This change does not alter existing behaviour, but enables future optimizations.