Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a couple non-applicable VIEW privileges from type-specific enums #394

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

dennishuo
Copy link
Contributor

Even though VIEW_CREATE is "about" views, as a privilege it's only applicable to NAMESPACE or CATALOG since views are created under namespaces (and at the catalog-level it means inheriting that for all child namespaces). This will be consistent with how TABLE_CREATE is already declared.

Remove VIEW_READ_PROPERTIES from the TablePrivilege enum; this appears to have been a simple typo.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Cleanup

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

Even though VIEW_CREATE is "about" views, as a privilege it's only applicable
to NAMESPACE or CATALOG since views are created under namespaces (and at the
catalog-level it means inheriting that for all child namespaces). This
will be consistent with how TABLE_CREATE is already declared.

Remove VIEW_READ_PROPERTIES from the TablePrivilege enum; this appears to
have been a simple typo.
@eric-maynard eric-maynard merged commit 02468e0 into apache:main Oct 22, 2024
5 checks passed
@dennishuo dennishuo deleted the dhuo-cleannup-type-privileges branch February 14, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants