-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: [Python] Fix exception in IOHandler.on_selectable_expired/update #364
base: main
Are you sure you want to change the base?
NO-JIRA: [Python] Fix exception in IOHandler.on_selectable_expired/update #364
Conversation
Here is a traceback:
|
Codecov Report
@@ Coverage Diff @@
## main #364 +/- ##
===========================================
+ Coverage 68.24% 88.36% +20.11%
===========================================
Files 367 47 -320
Lines 73285 2397 -70888
===========================================
- Hits 50011 2118 -47893
+ Misses 23274 279 -22995 Continue to review full report at Codecov.
|
@astitcher What do you think? |
…date This occasionally happens after my laptop wakes up from overnight sleep. IOHandler.on_selectable_expired() is invoked with `selectable` that has `_terminated=True` and `_transport=None` so when `IOHandler.update()` is called it crashes when trying to handle the exception (since transport is None). Fix this by checking if transport attribute is set and that selectable is not terminated before invoking `IOHandler.update()`. Signed-off-by: Ievgen Popovych <[email protected]>
4d22a80
to
8b75942
Compare
Could we get this PR merged? I ran into the bug recently. It causes qpid proton to be pretty unusable. |
I've opened a Jira issue for this https://issues.apache.org/jira/browse/PROTON-2776. |
This occasionally happens after my laptop wakes up from overnight sleep.
IOHandler.on_selectable_expired()
is invoked withselectable
that has_terminated=True
and_transport=None
so whenIOHandler.update()
is called it crashes when trying to handle the exception
(since transport is None).
Fix this by checking if transport attribute is set and that selectable is not
terminated before invoking
IOHandler.update()
.PROTON Jira issue: https://issues.apache.org/jira/browse/PROTON-2776