Skip to content

RANGER-5368:Improve unit test for TestPamLoginModule #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

RANGER-5368:Improve unit test for TestPamLoginModule #700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions ...thclient/src/test/java/org/apache/ranger/authentication/unix/jaas/TestPamLoginModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.junit.jupiter.api.TestMethodOrder;
import org.junit.jupiter.api.extension.ExtendWith;
import org.jvnet.libpam.PAM;
import org.jvnet.libpam.PAMException;
import org.jvnet.libpam.UnixUser;
import org.mockito.Mockito;
import org.mockito.junit.jupiter.MockitoExtension;
Expand Down Expand Up @@ -96,16 +97,31 @@ public void test02_commit_addsPrincipal_and_logout_clears_without_realPam() thro
}

@Test
public void test03_login_throwsLoginException_withRealPam() throws Exception {
public void test03_login_fullFlow_throwsFailedLoginException() throws Exception {
PamLoginModule m = new PamLoginModule();
Subject subject = new Subject();
Map<String, Object> opts = new HashMap<>();
opts.put(PamLoginModule.SERVICE_KEY, "sshd");
CallbackHandler cb = creds("alice", "bad");
m.initialize(subject, cb, new HashMap<>(), opts);
setField(m, "options", opts);

setField(m, "subject", subject);
setField(m, "callbackHandler", cb);
assertThrows(LoginException.class, m::login);
setField(m, "options", opts);

PAM mockPam = Mockito.mock(PAM.class);
Mockito.when(mockPam.authenticate(Mockito.eq("alice"), Mockito.eq("bad")))
.thenThrow(new PAMException("Authentication failed"));

setField(m, "pam", mockPam);

Method obtainUserAndPassword = PamLoginModule.class.getDeclaredMethod("obtainUserAndPassword");
obtainUserAndPassword.setAccessible(true);
obtainUserAndPassword.invoke(m);

Method performLogin = PamLoginModule.class.getDeclaredMethod("performLogin");
performLogin.setAccessible(true);
assertThrows(FailedLoginException.class, () -> invokeAndRethrowLoginException(m, performLogin));
}

@Test
Expand Down
Loading