RANGER-5399: Ranger: HTTP 403 - User '' lacks delegated-admin privile… #731
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge when attempting to GRANT privilege on a database
dhavalshah9131
requested review from
dineshkumar-yadav and
pradeepagrawal8184
vyommani
reviewed
Nov 13, 2025
| final boolean isKeyAdmin; | ||
|
|
||
| if (StringUtils.isEmpty(grantor)) { | ||
| if (StringUtils.isNotEmpty(bizUtil.getCurrentUserLoginId())) { |
Contributor
There was a problem hiding this comment.
The updated code changes the precedence of user selection. Originally, it prioritized the granter as the admin user, but now it favors the login user. Was this change intentional?
Also, the else block doesn't check if granter is null or empty. Please add this check for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ge when attempting to GRANT privilege on a database
What changes were proposed in this pull request?
Updated ensureAdminAccess() method to get user from session and if session is null get user from grantor passed.
How was this patch tested?
Build successful, tested for grant scenarios and working.