Skip to content

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented Jan 4, 2025

Fixes #9102 , skip the error unit test caused by incompatibility between fastjson version and jdk version.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.03%. Comparing base (c3c4101) to head (9f4c1bb).

Files with missing lines Patch % Lines
...c/main/java/org/apache/rocketmq/common/MixAll.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9103      +/-   ##
=============================================
+ Coverage      48.01%   48.03%   +0.02%     
- Complexity     12024    12033       +9     
=============================================
  Files           1312     1312              
  Lines          92659    92660       +1     
  Branches       11849    11849              
=============================================
+ Hits           44486    44510      +24     
+ Misses         42660    42630      -30     
- Partials        5513     5520       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix test cases instead of skipping them

@yx9o
Copy link
Contributor Author

yx9o commented Jun 29, 2025

Hi, @lizhanhui , @RongtongJin , here is the fix for bazel-compile ci. Some test errors under non-jdk8 are skipped. I can't get the specific error log, so I can only skip it first. This can be modified after unified support for jdk11. Currently, ci has passed. Let's see if it can be merged.

@RongtongJin
Copy link
Contributor

RongtongJin commented Jul 4, 2025

Hi, @lizhanhui , @RongtongJin , here is the fix for bazel-compile ci. Some test errors under non-jdk8 are skipped. I can't get the specific error log, so I can only skip it first. This can be modified after unified support for jdk11. Currently, ci has passed. Let's see if it can be merged.

Hi, @yx9o The tests cannot be skipped because other pipelines depend on JDK8. If skipped, these tests would remain uncovered in any pipeline. Since the Bazel pipeline's current failure is not an urgent issue, it is recommended to not skip these tests for now.

@yx9o
Copy link
Contributor Author

yx9o commented Jul 4, 2025

Hi, @lizhanhui , @RongtongJin , here is the fix for bazel-compile ci. Some test errors under non-jdk8 are skipped. I can't get the specific error log, so I can only skip it first. This can be modified after unified support for jdk11. Currently, ci has passed. Let's see if it can be merged.

Hi, @yx9o The tests cannot be skipped because other pipelines depend on JDK8. If skipped, these tests would remain uncovered in any pipeline. Since the Bazel pipeline's current failure is not an urgent issue, it is recommended to not skip these tests for now.

Hi @RongtongJin, you may not have noticed that we are not skipping jdk8 here, but only retaining the jdk8 tests. These tests have problems under jdk11. After unified adaptation to support jdk11, we will support testing for jdk11. How about that?

Copy link

@mengnankkkk mengnankkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本 PR 针对 fastjson 与 JDK 版本兼容性导致的 CI 单元测试失败,通过增加 isJdk8() 判断跳过相关测试,能有效解决当前问题。建议在 PR 描述或相关注释中补充说明此兼容性问题的背景,方便后续维护者理解。整体实现简洁明了,赞同合入。但没解决jdk11的支持。

@xuhongxu96
Copy link
Contributor

xuhongxu96 commented Aug 15, 2025

Hi all, #9610 should supersede this PR, as it keeps using JDK8 in Bazel build via custom toolchain, making most test cases runnable. Only 3 test suites are excluded (always fail, and 2 of them does not run in Maven build either) and 1 test case is skipped (unable to run in Bazel environment). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] bazel-compile (ubuntu-latest) ci error
6 participants