Add a Jetty event listener to start Derby when Roller is run via mvn jetty:run #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unfortunately this breaks the integration tests :( |
|
Bummer. I'll take another look over the weekend. I thought I had fixed the IT tests, except for the jdk21 run. |
|
@snoopdave oh you are right - I looked at the wrong workflow run! All good, my mistake. the jdk 21 run is easy to fix. its just the setup action requesting an early access build - i can fix this later. edit: opened #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression caused by switching Roller from using the Maven
btmatthewsinmemdbplugin and instead starting Derby by calling the embedded Derby server API directly (which works when tests are run either in IntelliJ or in Maven). The problem was that I forgot to add the same logic to the Maven Jetty plugin so that Derby is started when Roller is run viamvn jetty:run.The Jira ticket: https://issues.apache.org/jira/browse/ROL-2182