Skip to content

Conversation

kadolor
Copy link
Collaborator

@kadolor kadolor commented Apr 23, 2025

Did you read the Contributor Guide?

Is this PR related to a ticket?

  • No:
    • this is a documentation update. The PR name follows the format [DOCS] my subject

What changes were proposed in this PR?

How was this patch tested?

Did this PR include necessary documentation updates?

NA

@kadolor kadolor requested a review from jiayuasu as a code owner April 23, 2025 23:17
@kadolor kadolor marked this pull request as draft April 23, 2025 23:24
@kadolor kadolor requested a review from jiayuasu April 24, 2025 00:20
@kadolor kadolor marked this pull request as ready for review April 30, 2025 07:58
@jiayuasu jiayuasu requested a review from Copilot April 30, 2025 19:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new blog section to the documentation by updating navigation, adding blog plugin configurations in mkdocs.yml, and creating the blog landing page along with an authors file.

  • Adds a "Blog" entry to the site navigation and configures the blog plugin in mkdocs.yml.
  • Introduces a new blog index page with introductory content in docs/blog/index.md.
  • Provides an authors configuration file in docs/blog/.authors.yml to list blog authors.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
mkdocs.yml Adds a new "Blog" navigation entry and blog plugin configurations.
docs/blog/index.md Creates a new blog index page with introductory content.
docs/blog/.authors.yml Introduces an authors listing for the blog.

@kadolor kadolor requested a review from jbampton as a code owner May 6, 2025 01:12
@kadolor
Copy link
Collaborator Author

kadolor commented May 6, 2025

@jiayuasu Updated the insert-license hook in .pre-commit-config.yaml to also exclude Markdown files under docs/blog/posts/. This prevents the license header from conflicting with the YAML front matter required by MkDocs at the top of blog posts.

@jiayuasu
Copy link
Member

jiayuasu commented May 6, 2025

@kadolor The PR LGTM. Let me know when it is ready to be merged

Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-commit changes look fine.

Thanks !

Copy link
Collaborator

@MrPowers MrPowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Added some minor comments. Thank you!

jbampton and others added 3 commits July 28, 2025 23:27
…pache#2128)

* [apacheGH-2127] Add Shapely and WKT geometry support to STAC reader

 Enhanced the STAC reader to support Shapely geometry objects and WKT strings as spatial filters, providing more flexibility than
   the existing bbox-only approach. This improvement goes beyond pystac-client's capabilities while maintaining full backward
  compatibility.

  New Features

  - New geometry parameter added to all STAC client methods (search, get_items, get_dataframe, save_to_geoparquet)
  - Multiple input format support:
    - Shapely geometry objects (Polygon, etc.)
    - WKT strings (e.g., "POLYGON((0 0, 1 0, 1 1, 0 1, 0 0))")
    - Lists of mixed geometries and WKT strings
  - Smart precedence: When both bbox and geometry are provided, geometry takes precedence
  - Seamless integration with existing datetime and other filters

  Usage Examples

  from shapely.geometry import Polygon

  # Using WKT string
  items = client.search(geometry="POLYGON((0 0, 1 0, 1 1, 0 1, 0 0))")

  # Using Shapely polygon
  polygon = Polygon([(0, 0), (1, 0), (1, 1), (0, 1), (0, 0)])
  items = client.search(geometry=polygon)

  # Using list of geometries
  geometries = [polygon, "POLYGON((2 2, 3 2, 3 3, 2 3, 2 2))"]
  items = client.search(geometry=geometries)

  # Combined with other filters
  items = client.search(
      geometry=polygon,
      datetime=["2020-01-01T00:00:00Z", "2021-01-01T00:00:00Z"]
  )

* Update python/sedona/spark/stac/collection_client.py

Co-authored-by: Copilot <[email protected]>

* revert incorrect refactoring

---------

Co-authored-by: Copilot <[email protected]>
@kadolor kadolor self-assigned this Jul 30, 2025
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to install and run pre-commit locally.

For a lot of your commits the pre-commit workflow is failing.

This is wasting developer hours.

https://github.com/apache/sedona/actions/runs/16633333459/job/47068155537

@jbampton
Copy link
Member

Hey @kadolor you should come and hang out with the core team on Discord during work hours.

You are missing out on a lot of content and discussions.

A lot of us would like to meet you.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants