Do not return the instances from peer, if sync health check failed. #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wanghb1
reviewed
Mar 6, 2025
syncer/service/admin/health.go
Outdated
| checkWindow: NewHealthCheckWindow(8, 5), | ||
| // 同步恢复期间，最近6次检查，2次失败即视为不健康，即最多1次失败，90s。 | ||
| syncRecoveryWindow: NewHealthCheckWindow(6, 2), | ||
| shouldTrustPeerServer: true, // 默认信任对端，只有通过检查确认不对端琺连接，两个SC割裂，才认为对端不可信任 |
humingcheng
force-pushed
the
sync
branch
2 times, most recently
from
7f29735 to
a2172a8
Compare
… peer SC recovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.