Add more test cases on MySQLAuthSwitchResponsePacket (#33271)

* Add more test cases on MySQLAuthSwitchResponsePacket * Add more test cases on MySQLAuthSwitchResponsePacket
apache · Oct 16, 2024 · d4c7e85 · d4c7e85
1 parent 7e9c880
commit d4c7e85
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/...apache/shardingsphere/db/protocol/mysql/packet/handshake/MySQLAuthMoreDataPacketTest.java b/...apache/shardingsphere/db/protocol/mysql/packet/handshake/MySQLAuthMoreDataPacketTest.java
@@ -20,24 +20,28 @@
 import org.apache.shardingsphere.db.protocol.mysql.payload.MySQLPacketPayload;
 import org.apache.shardingsphere.infra.exception.generic.UnsupportedSQLOperationException;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+@ExtendWith(MockitoExtension.class)
 class MySQLAuthMoreDataPacketTest {
 
+    @Mock
+    private MySQLPacketPayload payload;
+
     @Test
     void assertNewWithInvalidHeader() {
-        MySQLPacketPayload payload = mock(MySQLPacketPayload.class);
         assertThrows(IllegalArgumentException.class, () -> new MySQLAuthMoreDataPacket(payload));
     }
 
     @Test
     void assertNewWithValidHeader() {
-        MySQLPacketPayload payload = mock(MySQLPacketPayload.class);
         when(payload.readInt1()).thenReturn(MySQLAuthMoreDataPacket.HEADER);
         when(payload.readStringEOFByBytes()).thenReturn(new byte[0]);
         MySQLAuthMoreDataPacket packet = new MySQLAuthMoreDataPacket(payload);
@@ -46,6 +50,6 @@ void assertNewWithValidHeader() {
 
     @Test
     void assertWrite() {
-        assertThrows(UnsupportedSQLOperationException.class, () -> new MySQLAuthMoreDataPacket(new byte[0]).write(mock(MySQLPacketPayload.class)));
+        assertThrows(UnsupportedSQLOperationException.class, () -> new MySQLAuthMoreDataPacket(new byte[0]).write(payload));
     }
 }
diff --git a/.../shardingsphere/db/protocol/mysql/packet/handshake/MySQLAuthSwitchResponsePacketTest.java b/.../shardingsphere/db/protocol/mysql/packet/handshake/MySQLAuthSwitchResponsePacketTest.java
@@ -23,8 +23,7 @@
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
 
-import static org.hamcrest.CoreMatchers.is;
-import static org.hamcrest.MatcherAssert.assertThat;
+import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 @ExtendWith(MockitoExtension.class)
@@ -36,9 +35,9 @@ class MySQLAuthSwitchResponsePacketTest {
     private final byte[] authPluginResponse = {0x22, 0x33};
 
     @Test
-    void assertMySQLAuthSwitchResponsePacket() {
+    void assertWrite() {
         when(payload.readStringEOFByBytes()).thenReturn(authPluginResponse);
-        MySQLAuthSwitchResponsePacket authSwitchResponsePacket = new MySQLAuthSwitchResponsePacket(payload);
-        assertThat(authSwitchResponsePacket.getAuthPluginResponse(), is(authPluginResponse));
+        new MySQLAuthSwitchResponsePacket(payload).write(payload);
+        verify(payload).writeBytes(authPluginResponse);
     }
 }