Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nativeTest under GraalVM Native Image for all E2E related unit tests #32614

Closed
wants to merge 1 commit into from

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Aug 21, 2024

For #29052.

Changes proposed in this pull request:

  • Add nativeTest under GraalVM Native Image for all E2E related unit tests.
  • It looks like the E2E Docker Image should not need to be rebuilt.
  • Is there no easy way to aggregate the execution of unit tests?
  • Commands like ./mvnw -PgenerateMetadata -DskipNativeTests -e clean test native:metadata-copy -Dtransaction.it.env.type=docker -Dtransaction.it.docker.mysql.version=mysql:5.7 are too verbose.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

pom.xml Outdated Show resolved Hide resolved
Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • From the unit test of ShardingSphere's Proxy Native, building an E2E image is something that can be avoided. At the current stage, executing E2E under GraalVM Native Image is actually a hassle for contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants