Merge the query process of series index #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ButterBright
commented
Aug 4, 2024
ButterBright
commented
- If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes [BanyanDB-Server] Optimizing Series Index Querying Performance skywalking#12239.
|
Pleaae update e2e tool version to fix CI |
hanahmily
requested changes
Aug 4, 2024
wu-sheng
reviewed
Aug 5, 2024
pkg/index/inverted/inverted.go
Outdated
| for i := range fieldKeys { | ||
| fields = append(fields, fieldKeys[i].Marshal()) | ||
| } | ||
| // TODO: add trace information |
There was a problem hiding this comment.
Should we finish todo in this pr?
There was a problem hiding this comment.
I agree. We should trace the query before merging it.
| } | ||
| // TODO: add node for Query |
hanahmily
requested changes
Aug 5, 2024
pkg/index/inverted/query.go
Outdated
| @@ -49,30 +49,22 @@ type GlobalIndexError struct { | |||
|
|
|||
| func (g GlobalIndexError) Error() string { return g.IndexRule.String() } | |||
|
|
|||
| var _ index.Query = (*Query)(nil) | |||
|
|
|||
| // Query is a wrapper for bluge.Query. | |||
| type Query struct { | |||
There was a problem hiding this comment.
Do you need to expose this type since its operations are wrapped by the index.Query?
|
What is the new query performance benchmark after this? |
|
Sorry for the late reply. I'm adding the relevant benchmarks. Theoretically, the topology queries should see a significant improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.