Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for topological queries #530

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

ButterBright
Copy link
Member

@ButterBright ButterBright commented Sep 8, 2024

The specification of the test environment is:
OS: Ubuntu 22.04.3 LTS x86_64
CPU: AMD EPYC 7282 (4) @ 2.794GHz
Memory: 7951MiB

Topological query benchmark results before series index optimization:
Metric Name, Min, Max, Mean, Median, P95
topology-0, 0.038543, 0.362319, 0.099407, 0.084507, 0.234849

Topological query benchmark results after series index optimization:
Metric Name, Min, Max, Mean, Median, P95
topology-0, 0.038886, 0.236007, 0.082450, 0.075451, 0.133140

Index query trace before optimization:
1

Index query trace after optimization:
2

As we can see, the topological query performance has improved, especially for p95. The index optimization proves effective, as expected.

@ButterBright ButterBright added this to the 0.7.0 milestone Sep 8, 2024
@hanahmily
Copy link
Contributor

@ButterBright Could you share the query tracing result between them? I want to ensure the scanning strategy is improved as we expected.

@ButterBright
Copy link
Member Author

Updated.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.27%. Comparing base (70557d3) to head (c1d3bdf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   51.25%   51.27%   +0.01%     
==========================================
  Files         165      165              
  Lines       20299    20299              
==========================================
+ Hits        10405    10409       +4     
+ Misses       9105     9102       -3     
+ Partials      789      788       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wu-sheng wu-sheng merged commit 59c3968 into apache:main Sep 12, 2024
14 checks passed
StLeoX pushed a commit to StLeoX/skywalking-banyandb that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants