feat: add toolkit logging impl #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shyunny <[email protected]>
Signed-off-by: shyunny <[email protected]>
Signed-off-by: shyunny <[email protected]>
mrproliu
requested changes
Sep 8, 2024
|
I don't see any changes of this PR, so please do not resolve the conversations. |
Signed-off-by: shyunny <[email protected]>
Signed-off-by: shyunny <[email protected]>
Signed-off-by: shyunny <[email protected]>
|
Block waiting for context test to complete |
mrproliu
reviewed
Sep 9, 2024
Signed-off-by: shyunny <[email protected]>
Signed-off-by: shyunny <[email protected]>
mrproliu
reviewed
Sep 9, 2024
Signed-off-by: shyunny <[email protected]>
|
This comment still not resolved: #202 (comment) |
mrproliu
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the
toolkit/loggingfeat, supports manually callingdebug/info/warn/errorto pass logs msg to the backend, and can be associated with the currently active span and traceExpanded the LogReporter interface, through which the current LogCtx can be obtained
Modified some code structures to make them look more structured