-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:add support goframe v2 #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, after the comment issues, there still has two things needs to be updated:
- Please update the [CHANGES.md] to announcement there have a new plugin enhanced.
- Please add a Plugin test to checking the plugin is work.
Good morning, I have fixed all the problems you reviewed, you can have a look at my latest submission, can it be merged into it? The latest submission is here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, please fix the CI and comments.
… support-plugins.md
Thank for the review, I have already fix the CI and comments. |
There seems to be some issues that were not caused by the plugin I submitted what can I do for this |
The comments were made, your code changes affect the lint check. |
Lint should be easy to check locally. Please make sure it passed before we cost too much CI resources. |
sorry ,Because I haven't installed Lint locally I have processed my plugin part, but it seems that some of the code for other modules in the project has not been validated by Lint |
All codes merged must pass lint check. so, all fails are related to your codes. |
Are you using the correct version of go lint? Different versions could result in different style details. |
I think if I make changes to these, the original author @mrproliu won't approve them for me |
We should not. The CI should be able to pass for no change code in the main branch. If your local setup can't, then there is a gap between these two(your local and our expectation) |
Thank ,You're right. I started using the latest version of golangci 1.61.0. |
Your plugin test failure, please fix it. |
@mrproliu Please recheck. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Once the CI passed, I think it could be merged.
Can you help me take a look this ci tags check problem? |
That's just a shell bug that shows the wrong scenario count, you can ignore it. |
add support goframe v2
goframe link:https://github.com/gogf/gf