Enhance the logrus logger plugin to support adapt without any settings method invoke
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs method invoke
mrproliu
added
documentation
wu-sheng
reviewed
Jul 12, 2023
| 1. `Logrus`: It automatically selects the current logger when executing functions such as `logrus.New`, `logger.SetOutput`, or `logger.SetFormatter`. | ||
| 2. `Zap`: It automatically selects the current logger when executing functions such as `zap.New`, `zap.NewNop`, `zap.NewProduction`, `zap.NewDevelopment`, or `zap.NewExample`. | ||
|
|
||
| If there are multiple different logging systems in your current application, the last-called logging system would be chosen. |
There was a problem hiding this comment.
What does last-called mean? Multiple logging systems usually mean hybrid logging usage, right?
There was a problem hiding this comment.
Multiple logging systems usually mean hybrid logging usage, right?
Yes.
What does
last-calledmean?
That means which logging system would be used on the agent logging. Hybrid logging usage permits logging uploader and tracing enhancement, but the Go Agent logging only needs to send the log to the one logging system.
wu-sheng
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.