add another subpath level to values.yaml
oap config override
#142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kezhenxu94's PR was a great enhancement that gave the ability to set oap config override files from within
values.yaml
. But it only allows us to override files that are up to 1 level deep under/skywalking/config
.For example:
alarm-settings.yaml
is directly under/skywalking/config
which is 0 levels deepcore.oal
is under/skywalking/config/oal/
which is 1 level deepWhy this PR?
SkyWalking has some configuration files like:
/skywalking/config/ui-initialized-templates/general/*
/skywalking/config/openapi-definitions/serviceA/*
Which are 2 levels deep and we need to have the ability to set them through
values.yaml
. So I just added one more level and now we can set override oap configurations this way2 levels
1 level
0 levels